Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated mod and dependencies for 1.18.2
While the mod works on newer versions, it throws an error on startup, and doesn't work with modmenu. I wanted to fix the error messages thrown on startup, and fix the modmenu config issue.
Notable changes:
Follow fabric and rename the mixin from ChatListenerHud to ChatHudListener, allowing successful building.
Update autoconfig1u to cloth-config
Update modmenu implementation.
Additionally, I updated various build settings and updated basically all of the dependencies.
Notably, I replaced autoconfig1u with cloth-config, which now bundles autoconfig. This fixes an error thrown on startup with newer MC versions. While it's possible to continue using autoconfig1u, that behavior isn't recommended and likely will cause breakage in the future. Hopefully, this will help future-proof the mod so it continues working, and additionally fixes the error message thrown on startup in 1.18.2. Note, this does have the effect of adding Cloth Config as a dependency, as it's not recommended to compile the mod with it included.