Conversation
| "package": "ncc build --minify", | ||
| "test": "NODE_OPTIONS='--experimental-vm-modules' jest", | ||
| "all": "npm test && npm run build && npm run package", | ||
| "all": "npm run format-check && npm test && npm run build && npm run package", |
There was a problem hiding this comment.
This is the only "manual" change in this PR. All the other changes come from the formatter.
There was a problem hiding this comment.
You can see I let the format-check fail in CI the first build before applying a commit with the fixes to verify the behavior.
mcafaro
left a comment
mcafaro
left a comment
There was a problem hiding this comment.
We should probably have some instructions for setting up npm format as a git commit hook.
I added our |
| ## Adding a pre-commit hook | ||
|
|
||
| You may choose to run all CI checks before each commit by adding a pre-commit hook. To do so, navigate to the repository root directory, and run the following commands: | ||
|
|
||
| _bash (Unix/macOS)_ | ||
|
|
||
| ```sh | ||
| echo '#!/bin/sh' > .git/hooks/pre-commit | ||
| echo 'npm run ci' >> .git/hooks/pre-commit | ||
| chmod +x .git/hooks/pre-commit | ||
| ``` | ||
|
|
||
| _Command Prompt (Windows)_ | ||
|
|
||
| ```cmd | ||
| echo #!/bin/sh > .git\hooks\pre-commit | ||
| echo npm run ci >> .git\hooks\pre-commit | ||
| ``` | ||
|
|
||
| _PowerShell (Windows)_ | ||
|
|
||
| ```pwsh | ||
| Set-Content .git\hooks\pre-commit '#!/bin/sh' | ||
| Add-Content .git\hooks\pre-commit 'npm run ci' | ||
| ``` | ||
|
|
||
| > **Note:** | ||
| > Git hooks are not version-controlled, so you’ll need to set up this hook for each fresh clone of the repository. |
There was a problem hiding this comment.
@mw-hrastega Most of this file is the same as what we have in our other repositories, but this section is new. It is primarily intended as documentation for the devs on our team, but I wanted to include you because it is part of a public repository.
There was a problem hiding this comment.
Sounds good. Added some comments.
Bumps [handlebars](https://github.com/handlebars-lang/handlebars.js) from 4.7.8 to 4.7.9. - [Release notes](https://github.com/handlebars-lang/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.9/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.8...v4.7.9) --- updated-dependencies: - dependency-name: handlebars dependency-version: 4.7.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
6 participants
We already had a
npm run format-checkthat fails the build and anpm run formatto fix locally available. This change just addsformat-checkto ourciscript so that the build will fail if there is a formatter finding. The user can correct them by runningnpm formatlocally and recommitting. I plan to make this change in all of our actions repos.