Skip to content

CLOPS-776 Proposed performance optimisation for migration of log_visit #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcel-innocraft wants to merge 1 commit into
base: 5.x-dev
Choose a base branch
from
Open

CLOPS-776 Proposed performance optimisation for migration of log_visit #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Db/BatchQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,9 @@ private function makeQuery($sql, $offset)
{
return $sql . ' LIMIT ' . (int)$this->limit . ' OFFSET ' . (int) $offset;
}

public function getLimit(): int
{
return $this->limit;
}
}
14 changes: 11 additions & 3 deletions Migrations/LogMigration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,22 @@ public function migrate(Request $request, TargetDb $targetDb)

$logActionMigration = new LogActionMigration();

$batchQuery = new BatchQuery();
$count = 0;

$loggedAt = array(0.05, 0.1, 0.2, 0.4, 0.6, 0.8, 0.9);

foreach ($batchQuery->generateQuery('SELECT * FROM ' . Common::prefixTable('log_visit') . ' WHERE idsite = ? ORDER BY idvisit ASC', array($request->sourceIdSite)) as $visitRows) {
$table = Common::prefixTable('log_visit');

$batchQuery = new BatchQuery();
$limit = $batchQuery->getLimit();

$sql = 'SELECT * FROM %s WHERE idsite = ? AND idvisit > ? ORDER BY idvisit ASC LIMIT %d';
$sql = sprintf($sql, $table, $limit);

$lastIdVisit = 0;
while ($visitRows = Db::fetchAll($sql, [$request->sourceIdSite, $lastIdVisit])) {
$count += count($visitRows);
$this->migrateVisits($visitRows, $request, $logActionMigration, $targetDb);
$lastIdVisit = end($visitRows)['idvisit'];

foreach ($loggedAt as $logAt) {
if ($numVisits && ($count / $numVisits) > $logAt) {
Expand Down
Loading