feat(room_list): make RoomListService updates subscriptions non-destructively#6652
Open
Johennes wants to merge 6 commits into
Open
feat(room_list): make RoomListService updates subscriptions non-destructively#6652Johennes wants to merge 6 commits into
Johennes wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6652 +/- ##
==========================================
+ Coverage 89.94% 89.99% +0.04%
==========================================
Files 382 382
Lines 108012 108112 +100
Branches 108012 108112 +100
==========================================
+ Hits 97152 97295 +143
+ Misses 7188 7154 -34
+ Partials 3672 3663 -9 ☔ View full report in Codecov by Harness. |
Johennes
commented
Jun 8, 2026
Comment on lines
178
to
187
| /// Replace all subscriptions to rooms by other ones. | ||
| /// | ||
| /// If the associated `Room`s exist, they will be marked as members are | ||
| /// missing, so that it ensures to re-fetch all members. | ||
| pub fn clear_and_subscribe_to_rooms( | ||
| &self, | ||
| room_ids: &[&RoomId], | ||
| settings: Option<http::request::RoomSubscription>, | ||
| cancel_in_flight_request: bool, | ||
| ) { |
Contributor
Author
Member
There was a problem hiding this comment.
What I had in mind was to change the current methods or add methods on RoomListService instead of changing what we have on the SlidingSync API.
Thoughts?
Contributor
Author
There was a problem hiding this comment.
I think doing it exclusively on the RoomListService level is tricky because the subscriptions are only known and locked in SlidingSync. I added a new method there now which I think is cleaner than my previous attempt of modifying the existing method.
Johennes
force-pushed
the
johannes/resubscribe-rooms
branch
from
09183ba to
8c866a4
Compare
Johennes
changed the title
Johennes
force-pushed
the
johannes/resubscribe-rooms
branch
from
8c866a4 to
81d3130
Compare
…uctively Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
johannes/resubscribe-rooms
branch
from
81d3130 to
7e789cc
Compare
Hywan
requested changes
Jun 23, 2026
…n-destructively Remove leftover print Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…n-destructively Extend doc comment Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Hywan
requested changes
Jun 25, 2026
…n-destructively Switch to retain Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…n-destructively Highlight that members won't be resynced Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…n-destructively Reformat Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With my Filament hat on.
Fixes: #6620
(see Writing changelog entries).