Sync: Add support for MSC4262 (Profile Updates Sliding Sync Extension).#6685
Sync: Add support for MSC4262 (Profile Updates Sliding Sync Extension).#6685pixlwave wants to merge 3 commits into
Conversation
# Conflicts: # Cargo.lock # Cargo.toml
Handling the responses is not yet handled.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6685 +/- ##
==========================================
- Coverage 89.86% 89.86% -0.01%
==========================================
Files 396 396
Lines 110264 110359 +95
Branches 110264 110359 +95
==========================================
+ Hits 99092 99170 +78
- Misses 7394 7406 +12
- Partials 3778 3783 +5 ☔ View full report in Codecov by Harness. |
|
This all looks mostly sensible. I thing I could spot, if we receive the profiles as part of the sync, then we should persist them in the store as part of a This ensures that all the changes a sync produces are persisted as part of a single DB transaction. This means you'll need to extend this struct: matrix-rust-sdk/crates/matrix-sdk-base/src/store/mod.rs Lines 539 to 586 in 412b5df And extend the logic which persists the changes from that struct. |
This PR makes the following additions:
Full disclosure: I do not understand SQL, all of that code is LLM generated and I don't have any confidence to say whether or not it is valid/performant/good. ORMs ftw 😄
Draft whilst still a WIP.