Skip to content

test: add integration test for declining an invite to an empty room#6686

Open
paul8711-code wants to merge 2 commits into
matrix-org:mainfrom
paul8711-code:test/empty-room-invite-decline-test
Open

test: add integration test for declining an invite to an empty room#6686
paul8711-code wants to merge 2 commits into
matrix-org:mainfrom
paul8711-code:test/empty-room-invite-decline-test

Conversation

@paul8711-code

Copy link
Copy Markdown
Contributor

This PR is related to #4642. I have added the first of two integration tests (as requested), according to which declining an invite worked just fine.

  • I've documented the public API changes in the appropriate changelog files (see Writing changelog entries).
  • This PR was made with the help of AI.

Signed-off-by: Paul8711 154304377+paul8711-code@users.noreply.github.com

Signed-off-by: Paul8711 <154304377+paul8711-code@users.noreply.github.com>
@paul8711-code paul8711-code requested a review from a team as a code owner June 24, 2026 15:16
@paul8711-code paul8711-code requested review from stefanceriu and removed request for a team June 24, 2026 15:16
@paul8711-code

Copy link
Copy Markdown
Contributor Author

@Hywan could you take a look at this PR when you have time? It is directly relevant to our discussion in the previously mentioned issue.

@paul8711-code paul8711-code changed the title test: add integration test for declining invite to empty room test: add integration test for declining an invite to an empty room Jun 24, 2026
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.90%. Comparing base (340bbc8) to head (f6829ad).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6686   +/-   ##
=======================================
  Coverage   89.89%   89.90%           
=======================================
  Files         396      396           
  Lines      110264   110264           
  Branches   110264   110264           
=======================================
+ Hits        99117    99128   +11     
+ Misses       7376     7375    -1     
+ Partials     3771     3761   -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Jun 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing paul8711-code:test/empty-room-invite-decline-test (f6829ad) with main (567463d)

Open in CodSpeed

@Hywan Hywan linked an issue Jun 25, 2026 that may be closed by this pull request
@Hywan Hywan requested review from Hywan and removed request for stefanceriu June 25, 2026 07:38

@Hywan Hywan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! I think we need to tweak it though, as it contains a flow right now.

Comment thread testing/matrix-sdk-integration-testing/src/tests/room.rs Outdated
@paul8711-code paul8711-code requested a review from Hywan June 25, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impossible to decline an invite to an empty room

2 participants