Skip to content

test: add integration test for accepting an invite to an empty room#6687

Open
paul8711-code wants to merge 2 commits into
matrix-org:mainfrom
paul8711-code:fix/empty-room-invite-accept-forbidden
Open

test: add integration test for accepting an invite to an empty room#6687
paul8711-code wants to merge 2 commits into
matrix-org:mainfrom
paul8711-code:fix/empty-room-invite-accept-forbidden

Conversation

@paul8711-code

Copy link
Copy Markdown
Contributor

This PR is related to #4642. I have added the second of the two requested integration tests, according to which accepting an invite did indeed not work, but instead threw a completely different error than mentioned.

  • I've documented the public API changes in the appropriate changelog files (see Writing changelog entries).
  • This PR was made with the help of AI.

Signed-off-by: Paul8711 154304377+paul8711-code@users.noreply.github.com

Signed-off-by: Paul8711 <154304377+paul8711-code@users.noreply.github.com>
@paul8711-code paul8711-code requested a review from a team as a code owner June 24, 2026 15:27
@paul8711-code paul8711-code requested review from Hywan and removed request for a team June 24, 2026 15:27
@paul8711-code

Copy link
Copy Markdown
Contributor Author

@Hywan could you also take a look at this PR? It too is relevant to our discussion in the mentioned issue.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2066 1 2065 0
View the top 1 failed test(s) by shortest run time
matrix-sdk-integration-testing::tests::room::test_empty_room_accept_invite
Stack Traces | 0.806s run time
Error: the server returned an error: [404 / M_UNKNOWN] Can't join remote room because no servers that are in the room have been provided.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codspeed-hq

codspeed-hq Bot commented Jun 24, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 40.36%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 49 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation Restore session [memory store] 167.6 ms 281 ms -40.36%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing paul8711-code:fix/empty-room-invite-accept-forbidden (b56fa22) with main (567463d)

Open in CodSpeed

Comment thread testing/matrix-sdk-integration-testing/src/tests/room.rs Outdated

@Hywan Hywan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! I think we need to improve it a bit though.

@Hywan Hywan linked an issue Jun 25, 2026 that may be closed by this pull request
@paul8711-code paul8711-code requested a review from Hywan June 26, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impossible to decline an invite to an empty room

2 participants