test: add integration test for accepting an invite to an empty room#6687
test: add integration test for accepting an invite to an empty room#6687paul8711-code wants to merge 2 commits into
Conversation
Signed-off-by: Paul8711 <154304377+paul8711-code@users.noreply.github.com>
|
@Hywan could you also take a look at this PR? It too is relevant to our discussion in the mentioned issue. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Merging this PR will degrade performance by 40.36%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | Restore session [memory store] |
167.6 ms | 281 ms | -40.36% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing paul8711-code:fix/empty-room-invite-accept-forbidden (b56fa22) with main (567463d)
Hywan
left a comment
There was a problem hiding this comment.
Thanks for the test! I think we need to improve it a bit though.
This PR is related to #4642. I have added the second of the two requested integration tests, according to which accepting an invite did indeed not work, but instead threw a completely different error than mentioned.
Signed-off-by: Paul8711 154304377+paul8711-code@users.noreply.github.com