Add a basic css-only lightbox to the figure shortcode#3262
Open
MTRNord wants to merge 1 commit into
Open
Conversation
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Deploying matrix-website with
|
| Latest commit: |
c91757e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88e0cbc6.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-figure-lightbox.matrix-website.pages.dev |
Contributor
|
this isn't working out on https://88e0cbc6.matrix-website.pages.dev/homeserver/official/#/ 🤔 |
Member
Author
Because they are too low res or why exactly? |
Contributor
|
Yeah, arguably the images in that case should just be bigger anyway. But I don't think we can generalise that pictures are always significantly bigger than displayed? In which cases the experience is a bit ridiculous. I can't think of a solution, except
|
HarHarLinks
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the lightbox from #3239 to the figure shortcode
Related issues
None
Role
Website & Content WG
Timeline
None
Signoff
See commits.