issue template: invite people to PR if they're up for it#3351
Conversation
See also matrix-org#3329 (comment) Signed-off-by: Arnout Engelen <arnout@bzzt.net>
HarHarLinks
left a comment
There was a problem hiding this comment.
technically our CONTENT.md speaks of requiring an accepted issue before implementation, however my tendency is to allow some leeway to ecosystem updates. the only contentious bit i see there is our unclear definition of what it means to support some of the named features, which however we should resolve anyway.
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com> Signed-off-by: Arnout Engelen <arnout@engelen.eu>
Actually it's https://github.com/matrix-org/matrix.org/blob/main/CONTRIBUTING.md#how-we-take-decisions :) I personally dislike such a rule, and prefer the "if you PR without creating an issue you risk us rejecting your PR, that's your risk" approach - but that's up to you of course.
Yeah fair. Indeed ElementX does know about threads somewhat, but it's so basic I didn't feel comfortable suggesting that would be 'supported'. Maybe it would be good to have a 'somewhat (see comment)' option :D |
|
The respective issue is #3230 |
|
Quoted from a previous comment:
I'm not against adopting such a change (or something similar) for pull requests that involve minor changes; it would help prevent situations like this from occurring. I also support clarifying when an issue is needed (e.g., for significant changes). |
Description
Highlight people comfortable with GitHub can also just PR.
Not sure how to test if this renders correctly tbh... maybe let's just try it.
Related issues
Discussed in #3329 (comment)
Role
Independent