Skip to content

issue template: invite people to PR if they're up for it#3351

Open
raboof wants to merge 2 commits into
matrix-org:mainfrom
raboof:issue-template-invite-PRs
Open

issue template: invite people to PR if they're up for it#3351
raboof wants to merge 2 commits into
matrix-org:mainfrom
raboof:issue-template-invite-PRs

Conversation

@raboof
Copy link
Copy Markdown
Contributor

@raboof raboof commented Apr 13, 2026

Description

Highlight people comfortable with GitHub can also just PR.

Not sure how to test if this renders correctly tbh... maybe let's just try it.

Related issues

Discussed in #3329 (comment)

Role

Independent

See also matrix-org#3329 (comment)

Signed-off-by: Arnout Engelen <arnout@bzzt.net>
@raboof raboof requested a review from a team as a code owner April 13, 2026 13:19
@HarHarLinks HarHarLinks added the meta Something concerning the repo itself, such as technical changes, contribution guidelines, and more. label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically our CONTENT.md speaks of requiring an accepted issue before implementation, however my tendency is to allow some leeway to ecosystem updates. the only contentious bit i see there is our unclear definition of what it means to support some of the named features, which however we should resolve anyway.

Comment thread .github/ISSUE_TEMPLATE/update-ecosystem-info.yaml Outdated
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: Arnout Engelen <arnout@engelen.eu>
@raboof
Copy link
Copy Markdown
Contributor Author

raboof commented Apr 13, 2026

technically our CONTENT.md speaks of requiring an accepted issue before implementation

Actually it's https://github.com/matrix-org/matrix.org/blob/main/CONTRIBUTING.md#how-we-take-decisions :)

I personally dislike such a rule, and prefer the "if you PR without creating an issue you risk us rejecting your PR, that's your risk" approach - but that's up to you of course.

the only contentious bit i see there is our unclear definition of what it means to support some of the named features, which however we should resolve anyway.

Yeah fair. Indeed ElementX does know about threads somewhat, but it's so basic I didn't feel comfortable suggesting that would be 'supported'. Maybe it would be good to have a 'somewhat (see comment)' option :D

@HarHarLinks
Copy link
Copy Markdown
Contributor

The respective issue is #3230

@awtj8o81ryywg793
Copy link
Copy Markdown
Contributor

awtj8o81ryywg793 commented Apr 13, 2026

Quoted from a previous comment:

I personally dislike such a rule, and prefer the "if you PR without creating an issue you risk us rejecting your PR, that's your risk" approach - but that's up to you of course.

I'm not against adopting such a change (or something similar) for pull requests that involve minor changes; it would help prevent situations like this from occurring. I also support clarifying when an issue is needed (e.g., for significant changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Something concerning the repo itself, such as technical changes, contribution guidelines, and more.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants