Improve summaries of some pages, and include in the opengraph description.#3409
Open
Half-Shot wants to merge 2 commits into
Open
Improve summaries of some pages, and include in the opengraph description.#3409Half-Shot wants to merge 2 commits into
Half-Shot wants to merge 2 commits into
Conversation
9b8f542 to
a2e9346
Compare
Deploying matrix-website with
|
| Latest commit: |
9b8f542
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4977ac0e.matrix-website.pages.dev |
| Branch Preview URL: | https://hs-improve-summaries.matrix-website.pages.dev |
Signed-off-by: Will Hunt <signoff@half-shot.uk>
Signed-off-by: Will Hunt <signoff@half-shot.uk>
a2e9346 to
df4978a
Compare
gewitternacht
approved these changes
May 13, 2026
awtj8o81ryywg793
requested changes
May 14, 2026
Contributor
awtj8o81ryywg793
left a comment
There was a problem hiding this comment.
Just a slight nitpick.
| +++ | ||
| title = "Room Directory WG" | ||
| template = "governing-board/working_group.html" | ||
| extra.summary = "This working group's primary purpose is receiving and processing requests about the room directory of the matrix.org homeserver." |
Contributor
There was a problem hiding this comment.
Any particular reason why the wording of this summary differs from the other Working Group summaries?
Why not the following?
Information about the Matrix.org Room Directory Working Group.
| +++ | ||
| title = "Governance WG" | ||
| template = "governing-board/working_group.html" | ||
| extra.summary = "Information about the Matrix.org Governance Working Group" |
Contributor
There was a problem hiding this comment.
Suggested change
| extra.summary = "Information about the Matrix.org Governance Working Group" | |
| extra.summary = "Information about the Matrix.org Governance Working Group." |
| +++ | ||
| title = "Events WG" | ||
| template = "governing-board/working_group.html" | ||
| extra.summary = "Information about the Matrix.org Events Working Group" |
Contributor
There was a problem hiding this comment.
Suggested change
| extra.summary = "Information about the Matrix.org Events Working Group" | |
| extra.summary = "Information about the Matrix.org Events Working Group." |
| title = "Security Hall of Fame" | ||
| template = "security-hall-of-fame.html" | ||
| aliases = ["/hall-of-fame"] | ||
| extra.summary = "Here we maintain a list of security researchers and their findings, to recognize them for having responsibly disclosed security issues to us in the past." |
Contributor
There was a problem hiding this comment.
Suggested change
| extra.summary = "Here we maintain a list of security researchers and their findings, to recognize them for having responsibly disclosed security issues to us in the past." | |
| extra.summary = "Here we maintain a list of security researchers and their findings to recognise them for having responsibly disclosed security issues to us in the past." |
/me puts on their en_GB compliance engineer hat on 🧢️
(I'm not too fussed with the comma, feel free to re-add it if you want.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Role
Timeline
Signoff
Please sign off your individual commits.