Create docker file, let the deployment and development more easier#265
Open
henryclw wants to merge 2 commits intomatrix-org:mainfrom
Open
Create docker file, let the deployment and development more easier#265henryclw wants to merge 2 commits intomatrix-org:mainfrom
henryclw wants to merge 2 commits intomatrix-org:mainfrom
Conversation
NOUIY
approved these changes
Jun 4, 2022
| RUN yarn | ||
|
|
||
| RUN yarn build | ||
|
|
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
Thank you for your reply, but I don't get what you're trying to say, do I need to have further modification on the Dockerfile? (e.g. https://github.com/henryclw/matrix.to/blob/dev-docker/Dockerfile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you need to publish the docker image at DockerHub, I can help to build a CI with that.