Moving static data out of Element client file#273
Moving static data out of Element client file#273thibaultamartin wants to merge 2 commits intomainfrom
Conversation
| this.data = data; | ||
| } | ||
|
|
||
| get id() { return this.data.id; } |
There was a problem hiding this comment.
Is it okay to snake case the project name as an id?
There was a problem hiding this comment.
not sure what you mean here. this line seems fine to me.
There was a problem hiding this comment.
@bwindels right now id is a field that only exist for matrix.to
At the moment for Element, the id is element.io.
Would it be ok to use element instead? I would derive the id from the project name (since two projects can't have the same name anyway)
| this.data = data; | ||
| } | ||
|
|
||
| get id() { return this.data.id; } |
There was a problem hiding this comment.
not sure what you mean here. this line seems fine to me.
| "applestorelink": new AppleStoreLink('vector', 'id1083446067'), | ||
| "playstorelink": new PlayStoreLink('im.vector.app'), | ||
| "fdroidlink": new FDroidLink('im.vector.app'), | ||
| "flathublink": new FlathubLink('im.riot.Riot'), |
There was a problem hiding this comment.
why not make these links something like this? You can wrap these strings into their *Link objects in Client.getInstallLinks, that way it's closer to json and people don't have to deal with knowing about these classes:
"installLinks": {
"applestore": ["vector", "id1083446067"],
"playstore": "im.vector.app",
"fdroid": "im.vector.app",
"flathub": "im.riot.Riot",
"website": "https://element.io/get-started"
}
There was a problem hiding this comment.
I think at that point "installLinks" becomes misleading, because im.vector.app isn't a link
There was a problem hiding this comment.
I would like as much of the content as possible to be generated by squiddy (to make sure it will be kept up to date).
The file format for squiddy is not completely dry yet, but for clients it would look like
[[clients]]
title = "Element Web"
description = "Element is a glossy web client with an emphasis on performance and usability"
maturity = "Stable"
(more fields…)
appstore_details.org = "vector"
appstore_details.app_id = "id1083446067"
playstore_app_id = "im.vector.app"
fdroid_app_id = "im.vector.app"
flathub_app_id = "im.vector.app"
otherinstall_link = ["https://element.io/get-started"]
full_description = """
Longer multi-line
description of the client
that can [include links](#) and `markdown in general`
"""
[[clients.authors]]
name = "Element"
[[clients.authors]]
name = "Kat"
matrix_id = "@kittykat:matrix.org"
[[clients.authors]]
name = "Danielle Kirkwood"
matrix_id = "@daniellekirkwood:one.ems.host"Under those circumstances, it's not a huge problem to use the classes. Is it acceptable for you?
thibaultamartin
force-pushed
the
use-json-for-clients-data
branch
from
93235c9 to
d5fdb35
Compare
3 participants
No description provided.