Prepare release of v5.0.0

[richvdh]

No description provided.

[helloskyline-a11y]

I believe it is because seshat-node/Cargo.toml still use seshat = "4.3.0" as dependency.
Maybe a random question, but why you don't use seshat = { version = "x.x.x", path = ".." }?

[richvdh]

Maybe a random question, but why you don't use seshat = { version = "x.x.x", path = ".." }?

Great question. @poljar ?

[poljar]

I believe it is because seshat-node/Cargo.toml still use seshat = "4.3.0" as dependency. Maybe a random question, but why you don't use seshat = { version = "x.x.x", path = ".." }?

Because the Cargo.toml file will be put into the node package as is. This means that if you try to build the node package it will attempt to find seshat at the path, thus the build will fail.

We use a patch override in the workspace toml file to override this and do depend on the path there.

[helloskyline-a11y]

Because the Cargo.toml file will be put into the node package as is. This means that if you try to build the node package it will attempt to find seshat at the path, thus the build will fail.

We use a patch override in the workspace toml file to override this and do depend on the path there.

Right, didn't know that. Looks fair, thanks!

[poljar]

Looks good.

[poljar]

I believe it is because seshat-node/Cargo.toml still use seshat = "4.3.0" as dependency. Maybe a random question, but why you don't use seshat = { version = "x.x.x", path = ".." }?

Because the Cargo.toml file will be put into the node package as is. This means that if you try to build the node package it will attempt to find seshat at the path, thus the build will fail.

We use a patch override in the workspace toml file to override this and do depend on the path there.

This is somewhat tersely documented in the workspace toml file:

seshat/Cargo.toml

Lines 63 to 67 in a0d88f9

	[patch.crates-io]
	# Ensure that seshat-node uses the local seshat version.
	#
	# The Cargo.toml file in the seshat-node directory needs to point to a published
	# version as we're packaging and publishing this Cargo.toml file as is.