Developments for boosted category#46
Draft
TizianoBevilacqua wants to merge 9 commits intomatteomalucchi:mainfrom
Draft
Developments for boosted category#46TizianoBevilacqua wants to merge 9 commits intomatteomalucchi:mainfrom
TizianoBevilacqua wants to merge 9 commits intomatteomalucchi:mainfrom
Conversation
…ed mass to FatJet collection
…ding vbf boosted category
… DNN variables for boosted topology
Owner
There was a problem hiding this comment.
I see you added the boosted part to the workflow_common. can you move the changes for that to another workflow_boosted in your config directory like done for vbf? For consistency the workflow_common contains basically all the functions but then the specific options (for e.g. boosted or vbf) are in the specific workflows which inherit from the common one. Like this we manage to share the functions without overcharging the workflow_common with the specifc cases. In the workflow_boosted you can basically inherit all the methods and only extend/change the apply_object_preselection and process_after_preselection. The new function for the boosted dnn variables can stay in the workflow common. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of selections and regions for the boosted category