-
Notifications
You must be signed in to change notification settings - Fork 4
fix(e2e): webhook-driven, auto-versioned CMT + fix non-PR dispatch 422 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yasserfaraazkhan
wants to merge
19
commits into
master
Choose a base branch
from
fix/cmt-direct-dispatch-and-cleanup-endpoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5080a9c
fix(cmt): add /cmt_dispatch and /cleanup_e2e endpoints
1dd004a
test(cmt): unit tests for /cmt_dispatch and /cleanup_e2e
d0e3d60
fix(e2e): remove dead mw_tracking_key primary cleanup path
e0c42f2
fix(e2e): make CMT webhook-driven; stop sending undeclared mw_trackin…
yasserfaraazkhan 83c0fe0
fix(e2e): scope SHA cleanup by flow so concurrent same-SHA runs aren'…
yasserfaraazkhan a2293fd
chore(cmt): default CMT versions to latest ESR/feature patches (10.11…
yasserfaraazkhan 8af9a48
feat(cmt): raise CMT version cap from 5 to 10
yasserfaraazkhan 48abfce
feat(cmt): auto-derive CMT server versions from Mattermost releases
yasserfaraazkhan 51fb239
Fix non-PR E2E cleanup: key on dispatch-time branch HEAD SHA
yasserfaraazkhan 26da5ac
Auto-expire PR E2E instances and evict their tracking entries
yasserfaraazkhan 5982567
Gate CMT trigger to release branches or manual dispatch
yasserfaraazkhan 6c10c35
CMT: stop sending unused cmt_run_id input on dispatch
yasserfaraazkhan 0db7844
CMT: trigger on RC tag cuts (vX.Y.Z-rc.N) in addition to manual dispatch
yasserfaraazkhan 0ab5fd1
CMT: also trigger on mobile build-release-NNN branches
yasserfaraazkhan 9d50896
push: skip desktop release-branch E2E (replaced by CMT RC-tag trigger)
yasserfaraazkhan 2d3335c
push: remove release-branch E2E trigger (release-X.Y push)
yasserfaraazkhan afeb5cf
push: skip mobile main-branch E2E (per-PR-merge cost too high)
yasserfaraazkhan bdb6970
cmt: latest-marker for mobile CMT + remove dead nightly/release-trigg…
yasserfaraazkhan d65b042
push: drop dead `nightly` param from desktop e2e dispatch
yasserfaraazkhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we planning to update these versions? Might better discuss in DM.
If understood correctly, the logic is to set
"CMTServerVersions: []"in order to allowmatterwickget the latest supported version and provisions instances for those versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NARSimoes https://github.com/mattermost/gitops-platform/pull/72/changes#diff-d242a4ffee35793c04e9591a799f9136234ba74b276617420390641ae142aa9fR96
the deployed values will be empty so it will fetch the latest versions. In this config the values is just placeholders for demo purpose.