Skip to content

Fix vault allowed origins when domain changes#91

Merged
matthiastjong merged 2 commits into
matthiastjong:mainfrom
steve-wecompare:fix/vault-domain-allowed-origins
May 29, 2026
Merged

Fix vault allowed origins when domain changes#91
matthiastjong merged 2 commits into
matthiastjong:mainfrom
steve-wecompare:fix/vault-domain-allowed-origins

Conversation

@steve-wecompare
Copy link
Copy Markdown
Contributor

Summary

  • Normalize vault item domains before deriving allowed origins so URL input does not produce https://https://....
  • Recompute allowedOrigins when an item domain is edited, including clearing origins when the domain is cleared.
  • Preserve explicitly provided allowedOrigins when callers pass them.

Tests

  • npm run check
  • DOCKER_HOST=unix:///Users/dagobotduck/.colima/default/docker.sock TESTCONTAINERS_RYUK_DISABLED=true npx vitest run tests/integration/vaults.test.ts
  • DOCKER_HOST=unix:///Users/dagobotduck/.colima/default/docker.sock TESTCONTAINERS_RYUK_DISABLED=true VAULT_ENCRYPTION_KEY=<32-byte-base64> npm test

@matthiastjong matthiastjong merged commit 0fd2a55 into matthiastjong:main May 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants