add updateMax method - #15
Open
mboukhalfa wants to merge 2 commits into
Open
Conversation
added 2 commits
January 15, 2019 23:45
mattlewis92
requested changes
Feb 3, 2019
mattlewis92
left a comment
mattlewis92
left a comment
Owner
There was a problem hiding this comment.
Nice one, thanks for this! 😄 Would you mind adding a test for this change? You can adapt one from here: https://github.com/mattlewis92/angular-gauge/blob/master/test/gauge.component.spec.ts#L59-L71
|
Sadly, this will not fix the issue, because gauge-svg method for updating max value doesn't update gauge itself. I have created pull request to fix that (naikus/svg-gauge#61). Afterwards, i will create also pull request to fix it here (along with tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a problem when updating the Max value for the gauge, the function
updateMax()which call thesetMaxValue()function in gauge-svg was missed.