Add format-ignore-exit-code configuration#285
Merged
mattn merged 4 commits intomattn:masterfrom Feb 1, 2026
Merged
Conversation
sirreal
commented
Nov 5, 2024
| LintOnSave bool `yaml:"lint-on-save" json:"lintOnSave"` | ||
| FormatCommand string `yaml:"format-command" json:"formatCommand"` | ||
| FormatCanRange bool `yaml:"format-can-range" json:"formatCanRange"` | ||
| FormatIgnoreExitCode bool `yaml:"format-ignore-exit-code" json:"formatIgnoreExitCode"` |
Contributor
Author
There was a problem hiding this comment.
There's a big whitespace diff here, but only this line was changed.
Owner
|
Thank you. Could you please fix conflict? |
Contributor
Author
|
@mattn I've merged master with the schema freshly regenerated. This is now conflict free. |
Contributor
Author
|
It's tricky to generate the schema with the correct versions. For posterity, this is what I did: docker run -it -v "$(pwd):/app" -w /app python:3.12-alpine sh -c "apk add --no-cache bash make && pip install json-schema-for-humans==0.45.2 && make schema_doc" |
Owner
|
Thank you |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new configuration option to ignore formatter exit codes.
Some formatters use non-zero exit codes when formatting was successful. See #183.
For example,
phpcbfuses a non-zero exit code that cannot be configured at this time: squizlabs/PHP_CodeSniffer#2898Fixes #183.
#271 can likely also be closed with if this change lands.