Open
Conversation
- There are a few places that use `&&` instead of `&` to mask bits out of sendMode, which doesn't actually mask out the bits. - Another place is missing parens, so it ends up comparing the last flag instead of the masked value. - The net result is that changing the sendMode doesn't work in a variety of different cases.
Author
|
I just realized that sendthreadsafe.c is copied into py-appscript and rb-appscript almost verbatim; the only changes are the filenames, the And the Python and Ruby versions have the same bug, which I assume will make I'll try to find a way to test that, and then either replace this pull request with one that fixes all of the languages, or add a new one for the other languages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
&&instead of&to mask bits outof sendMode, which doesn't actually mask out the bits.
flag instead of the masked value.
variety of different cases.