Pull 2.4.1 from ppannuto/python-titlecase#7
Merged
Conversation
Contributor
Author
|
@mattstevens please create a new tag. The last tag still points to a version from 2013 and that's the only version that users of this package in Sublime Text will see (ie. none of the recent changes are actually reaching any new or existing users). |
Owner
|
Yes I'm aware, I want to do some testing before publishing a new release. |
Contributor
Author
|
Just a friendly reminder to tag :) There shouldn't that much to test, it's a thin wrapper around a publicly available lib, any bugs would be with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked into the possibility of importing from a dependency. However, titlecase is only distributed as a source tarball, not as a wheel. Which is not supported in Sublime, at least not the way that source repo is organized. Vendoring remains the simplest way of doing it, and although it will probably fall behind again it's not like this thing is very volatile.
This PR updates titlecase to the last published version. That's a much better idea than my previous PR (#6). That way #1, #2 and #5 can also be closed.
Because the license requires that ("The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.") I also included the original license, and for completeness sake the credits to the authors.
Hopefully you're willing to merge this PR as well. Please don't forget to tag the latest version of this repo, Package Control only looks at tags, so without the tag these improvements don't reach users of the package.