Bridge Discord call state notices#229
Draft
Adri11334 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
This uses
discordgo.Message.Call, so the bridge PR should stay draft until the dependency lands and the module can be bumped normally.Summary
Keeps Discord private call notices up to date using call message metadata and voice state events.
Changes
message.call.participantsmessage.call.ended_timestamp, including short human-readable durationsMESSAGE_UPDATEpayloadsVOICE_STATE_UPDATEjoin/leave eventsExpected behavior
1:1 DMs:
(caller started a call. Use the Discord app to answer.)(You are in a call with caller. Use the Discord app to manage the call.)(caller started a call that lasted 9s.)Group DMs:
(caller started a call. 2 people are in the call. Use the Discord app to join.)(caller started a call. 3 people are in the call. Use the Discord app to manage the call.)(caller started a call that lasted 2m 3s.)Testing
go test ./pkg/msgconv ./pkg/connector -run 'TestRenderDiscordCallMessage|TestFormatDiscordCallDuration|TestFillMissingMessageUpdateFieldsPreservesCallContext|TestDiscordCallState' -count=1go test ./... -run '^$'pre-commit run --all-files