Fix GuidedValueSlider overlapping toolbar#13715
Merged
Merged
Conversation
Co-authored-by: DonLakeFlyer <5876851+DonLakeFlyer@users.noreply.github.com>
Co-authored-by: DonLakeFlyer <5876851+DonLakeFlyer@users.noreply.github.com>
Co-authored-by: DonLakeFlyer <5876851+DonLakeFlyer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GuidedValueSlider positioning behind the toolbar
Fix GuidedValueSlider overlapping toolbar
Dec 8, 2025
DonLakeFlyer
marked this pull request as ready for review
December 10, 2025 18:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI layout bug where the GuidedValueSlider component was rendering behind the toolbar in FlyView. The fix adds a top margin calculation that accounts for the toolbar height, ensuring the slider appears below the toolbar with appropriate spacing.
- Added
anchors.topMarginproperty toGuidedValueSliderusing the established patterntoolbar.height + _widgetMargin - This matches the existing layout pattern used by
widgetLayer(line 128) - The fix is minimal and follows QGC's QML anchoring conventions
HTRamsey
pushed a commit
to HTRamsey/qgroundcontrol
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GuidedValueSlider was anchored to
parent.topwithout margin, causing it to render behind the toolbar.Added
anchors.topMargin: toolbar.height + _widgetMarginfollowing the existing pattern fromwidgetLayer. This positions the slider below the toolbar with consistent visual spacing.Changed:
src/FlyView/FlyView.qmlline 170: Added topMargin anchor propertyTest Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.