System libs build#14043
Closed
NICourced wants to merge 71 commits into
Closed
Conversation
This would cause huge leaks if the stream was continuously restarting due to video timeout
This way we don't hammer the main thread with silly work
This reverts commit e0f6a0a.
This reverts commit ddd97ad.
Updated the LandingComplexItem recalculation logic to properly handle waypoint approach items, fixing several issues with heading calculations and when loading plans, such as the loiter radius being taken into account despite the "Use loiter to altitude" option being disabled. Refactored the relevant areas to unify the naming and logic between waypoint and loiter-based approaches. This replaces previous GUI-level workarounds (ddd97ad, e0f6a0a) that partially fixed these heading calculation problems by manipulating the loiter radius. This commit addresses the root cause instead, so it also fixes the issues for VTOL landing sequences, where the GUI workarounds hadn't yet been applied. Key changes: - Updated the coordinate recalculation logic to handle waypoint and loiter approaches as distinct modes, rather than forcing the waypoint approach through the loiter-based architecture. - Added _recalcFromApproachModeChange method to properly handle switching between loiter and waypoint approach items, instead of using the generic coordinate change handler. - Renamed "loiter tangent" to "slope start". - Updated all UI components to remove some explicit approach item-dependant logic which is no longer needed, and to use the new naming.
* This makes it fit on small screens like Herelink * Tried supporting dynamic single/double columns based on size but too complicated
Fixes compass rotation setting off by one on rotation param set
This supports request for standard modes. It will also on a delay report new modes available which should trigger a new mode query and ui update.
This fixes a bug where extremely long legs in flight plans were drawn as straight lines on the map, instead of following the great circle path. Key changes: - Break down mission legs longer than 50km into smaller segments that follow the great circle path. - Update leg arrow heading calculation to account for changing bearing along great circle paths.
- Ensure stream info is updated for all video receivers, including thermal streams. - Update auto-stream configuration logic for reliability when changing video sources or camera settings. - Motivation: Fixes issue where video stream would not update properly in the UI after switching cameras or stream types.
This allows you to go past where tiles exists but mirrors how 4.4 works. It allows you to go as far as possible zoomed in.
Fixes a bug in the telemetry color picker dialog where the wrong color value was passed on acceptance. Changed the onAccepted handler to use selectedColor instead of color to ensure the correct hex color value is used when updating telemetry colors. Changes: - Modified colorPickerDialog's onAccepted from: onAccepted: updateColorValue(colorIndex, color)
Add TapHandler to block click event leakage to underlying map
Wasn't waiting long enough for queued recalcs to flow through
The inner circle in the PhotoVideoControl widget was not always perfectly centered due to a bug in Qt's anchors.centerIn property (QTBUG-95224) which causes it to return integer positions instead of subpixel values. Implemented a workaround by setting alignWhenCentered to false. Related Qt bug: https://bugreports.qt.io/browse/QTBUG-95224 Qt fix commit: qt/qtdeclarative@fd23a22
) * Initial plan * Fix Android SD card permissions for API 30+ - Add MANAGE_EXTERNAL_STORAGE permission to manifest for Android 11+ full SD card access - Replace deprecated QtAndroidPrivate permission APIs with Java-based implementation - Add proper permission handling for Android 11+ (API 30) and Android 6+ (API 23) - Fix permission check to open settings for MANAGE_EXTERNAL_STORAGE grant on Android 11+ Co-authored-by: HTRamsey <68555040+HTRamsey@users.noreply.github.com> * Fix QJniObject::callStaticMethod usage for boolean return Co-authored-by: HTRamsey <68555040+HTRamsey@users.noreply.github.com> * Fix SD card path detection for Android 11+ Use StorageVolume.getDirectory() API for Android 11+ instead of deprecated reflection-based getPath() method. This fixes the "/dev/null" path issue where the reflection method returns invalid paths on newer Android versions. Co-authored-by: HTRamsey <68555040+HTRamsey@users.noreply.github.com> * Fix Android Activity Name --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: HTRamsey <68555040+HTRamsey@users.noreply.github.com> Co-authored-by: Holden <htramsey98@gmail.com>
Contributor
Build ResultsPlatform Status
Some builds failed. Pre-commit
Pre-commit hooks: 31 passed, 79 failed, 10 skipped. Updated: 2026-02-27 11:21:11 UTC • Triggered by: Android |
|
@NICourced, I think we need to open a new PR. As far as I understand, commits that aren’t yours weren’t supposed to end up here. |
Contributor
|
No idea what this is about? Re-open with at least some basic description if you want us to consider it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
System libs build
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).