fix(skill): add multi-line suggestion range minimization guidance#1311
Merged
Conversation
The review bot posted a suggestion on PR #1309 with start_line covering correct code (the git-wt elseif branch) along with the duplicate else block. Applying it would have removed a legitimate fallback path. Add explicit guidance to verify that every line in a multi-line suggestion range actually needs changing before posting. Closes #1310 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review-prskill requiring that multi-line suggestion ranges be minimized to only lines that need changingContext
In PR #1309 (run 22768248402), the review bot correctly identified a PowerShell syntax error (duplicate
elseblocks) but posted a suggestion withstart_line: 18, line: 22that would have removed the legitimategit-wtfallback branch along with the duplicate. The correct fix only needed to cover lines 20-22.Closes #1310
Test plan
🤖 Generated with Claude Code