Skip to content

skills(running-tend): weigh root-cause fix over lossy config workaround#3414

Merged
max-sixty merged 1 commit into
mainfrom
daily/review-runs-29081037464
Jul 10, 2026
Merged

skills(running-tend): weigh root-cause fix over lossy config workaround#3414
max-sixty merged 1 commit into
mainfrom
daily/review-runs-29081037464

Conversation

@worktrunk-bot

Copy link
Copy Markdown
Collaborator

Adds a triage rule to running-tend capturing a maintainer-flagged bad case from the daily review-runs analysis.

The bad case

In #3390 (triage of #3389), triage of the branch_worktree_mismatch flag shipped a docs-only PR recommending users reconfigure worktree-path = "{{ branch | basename }}". On #3390 the maintainer pushed back — "why do we drop the prefix?" — then explicitly asked to log it as a bad case and closed the PR.

Two problems the rule targets:

  • Lossy workaround presented as the fix. basename collapses alice/foo and bob/foo to foo, colliding on one directory, whereas the default {{ branch | sanitize }} keeps them distinct (alice-foo / bob-foo). The collision downside only surfaced after the maintainer challenged it.
  • Jumped to a docs workaround over the root-cause code fix. The proportionate fix was teaching the path-match check to tolerate a dropped namespace prefix, not asking every affected user to adopt a lossy template. The "docs-only, no risk" framing masked a bad recommendation — low code risk ≠ good guidance.

The rule

A new ### Weigh the root-cause fix before shipping a config/docs workaround subsection under Issue Triage, placed right after "Suggesting Aliases for Niche Feature Requests" (which encourages config-based deflection) as a tempering counterpoint: check whether a configurable workaround is lossy/foot-gunny, weigh a proportionate root-cause code fix first, and surface any recommended config's downsides up front.

Gate assessment

  • Gate 1 (confidence): Critical — directly flagged by @max-sixty ("log this as a bad case"). 1 occurrence is sufficient at Critical.
  • Gate 2 (magnitude): Targeted one-subsection addition; evidence bar met by the Critical maintainer flag.

Already recorded in the review-runs-tracking evidence log. Kept as a separate atomic PR from the open cargo-PATH skill note (#3361) — different concern, non-overlapping section.

Run 29081037464 · daily review-runs

Captures the maintainer-flagged bad case from PR #3390 / issue #3389:
triage shipped a docs-only PR recommending a lossy worktree-path template
(branch | basename collides alice/foo and bob/foo) as the fix, instead of
weighing the proportionate root-cause code fix. Adds a triage subsection to
check whether a config workaround is lossy and prefer the root-cause fix.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@worktrunk-bot worktrunk-bot added the review-runs Findings from the daily review-runs workflow label Jul 10, 2026
@max-sixty max-sixty merged commit f250877 into main Jul 10, 2026
37 of 47 checks passed
@max-sixty max-sixty deleted the daily/review-runs-29081037464 branch July 10, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runs Findings from the daily review-runs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants