skills(running-tend): weigh root-cause fix over lossy config workaround#3414
Merged
Conversation
Captures the maintainer-flagged bad case from PR #3390 / issue #3389: triage shipped a docs-only PR recommending a lossy worktree-path template (branch | basename collides alice/foo and bob/foo) as the fix, instead of weighing the proportionate root-cause code fix. Adds a triage subsection to check whether a config workaround is lossy and prefer the root-cause fix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a triage rule to
running-tendcapturing a maintainer-flagged bad case from the daily review-runs analysis.The bad case
In #3390 (triage of #3389), triage of the
⚑branch_worktree_mismatchflag shipped a docs-only PR recommending users reconfigureworktree-path = "{{ branch | basename }}". On #3390 the maintainer pushed back — "why do we drop the prefix?" — then explicitly asked to log it as a bad case and closed the PR.Two problems the rule targets:
basenamecollapsesalice/fooandbob/footofoo, colliding on one directory, whereas the default{{ branch | sanitize }}keeps them distinct (alice-foo/bob-foo). The collision downside only surfaced after the maintainer challenged it.The rule
A new
### Weigh the root-cause fix before shipping a config/docs workaroundsubsection under Issue Triage, placed right after "Suggesting Aliases for Niche Feature Requests" (which encourages config-based deflection) as a tempering counterpoint: check whether a configurable workaround is lossy/foot-gunny, weigh a proportionate root-cause code fix first, and surface any recommended config's downsides up front.Gate assessment
Already recorded in the review-runs-tracking evidence log. Kept as a separate atomic PR from the open cargo-PATH skill note (#3361) — different concern, non-overlapping section.
Run 29081037464 · daily review-runs