Skip to content

Implement waitingfor#23

Open
santiagocanti wants to merge 6 commits intomaxcnunes:masterfrom
santiagocanti:implement-waitingfor
Open

Implement waitingfor#23
santiagocanti wants to merge 6 commits intomaxcnunes:masterfrom
santiagocanti:implement-waitingfor

Conversation

@santiagocanti
Copy link

Added the option -waitingFor which is going to show only the hosts waitforit is waiting for.

The debug option was too much verbose and I found this solution to be a middle ground between having no information at all or having too much.

It looks like this:
image

I'm new to go so if there is something horrible done, please forgive me :)
Also, I tried running the tests for quite a while (running inside a docker container) but wasn't able to, not sure if I could get some help with that.

Thanks for this awesome utility!

@coveralls
Copy link

coveralls commented Sep 14, 2018

Pull Request Test Coverage Report for Build 58

  • 38 of 69 (55.07%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 48.529%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 2 0.0%
network.go 38 67 56.72%
Files with Coverage Reduction New Missed Lines %
network.go 1 75.61%
Totals Coverage Status
Change from base Build 54: -0.6%
Covered Lines: 132
Relevant Lines: 272

💛 - Coveralls

@maxclaus
Copy link
Collaborator

hey @santiagocanti great idea. I will review it once I have some free time.
Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants