Fix external file watching and add reload command (fixes #8)#10
Open
maxeonyx wants to merge 4 commits into
Open
Fix external file watching and add reload command (fixes #8)#10maxeonyx wants to merge 4 commits into
maxeonyx wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Out-of-workspace replacement files (configured via
replacementsFiles) are loaded once at activation but never refreshed.vscode.workspace.createFileSystemWatcheronly fires events for files inside a workspace folder, so changes to external config files (e.g. in dotfiles or home directories) are silently ignored until the user reloads the entire window.Solution
fs.watch()fallback for replacement files that resolve outside any workspace folderReload Replacement Filescommand for manual refreshcreateFileSystemWatcherfor in-workspace files (it works correctly there)Fixes #8