Clarify media service wiring to follow clean/old architecture#1760
Open
Chaitanyabeeraka11 wants to merge 4 commits intomaxrave-dev:mainfrom
Open
Clarify media service wiring to follow clean/old architecture#1760Chaitanyabeeraka11 wants to merge 4 commits intomaxrave-dev:mainfrom
Chaitanyabeeraka11 wants to merge 4 commits intomaxrave-dev:mainfrom
Conversation
…sappearing-on-pause Keep media notification visible when paused by adding SimpMusicMediaService
…-disappearing-on-pause Document media service placement in AndroidManifest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a manifest comment at the media service declaration to explicitly document the architecture boundary: keep the service implementation in the media module (com.maxrave.media3.service.SimpleMediaService) and avoid app-layer overrides. This directly addresses the “follow clean architecture and old architecture” review direction.