fix: refresh search tabs correctly and prevent playlist re-download loop#1775
Open
G-kylexy wants to merge 2 commits intomaxrave-dev:mainfrom
Open
fix: refresh search tabs correctly and prevent playlist re-download loop#1775G-kylexy wants to merge 2 commits intomaxrave-dev:mainfrom
G-kylexy wants to merge 2 commits intomaxrave-dev:mainfrom
Conversation
- Ensure searchAll() is called across search inputs instead of active tab-specific functions. - Fix download loop when adding undownloaded tracks to a fully downloaded playlist by guarding state transitions.
Added launchSingleTop and popUpTo for bottom navigation icons to avoid keeping multiple copies of the same tab sequence when clicking the bottom bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes: 1) Ensures that submitting a new search query properly refreshes all active tabs by calling searchAll() instead of tab-specific searches. 2) Prevents an infinite download loop when adding an undownloaded track to a fully downloaded playlist by properly guarding the state transition from DOWNLOADED to DOWNLOADING.