Add return_null option for partition#45
Open
soyking wants to merge 5 commits intomaxtepkeev:masterfrom
Open
Conversation
Contributor
Author
|
hmm… werid error, seems irrelevant with the changes |
Owner
|
I restarted the job and tests are passing now. You're right, there're some limitations which I need to think about before considering whether to merge this or not. Anyway great work, really appreciate it. Let's keep this PR open for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #26 #43, use
RETURN NULLcould accelerate the insert action. So here I add thereturn_nulloption when usearchitect.install. It will create the before-insert-trigger without return value and won't create the after-insert-trigger in PostgreSQL.But there are many limitations:
djangopony(psycopg2)sqlalchemy(psycopg2)andsqlobject(psycopg2), user should maintain the model's primary id as I did in tests. In some situations, such as using uuid as the primary key.It's ok if the MR won't be merged since there are too many limitations which should be declare cleary in documents. Actually I want to know if it could pass the tests in travis :)