Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a "Virtual File System" by implementing a unified resource management system that abstracts different resource types (files, directories, shared memory, message endpoints) behind a common interface. The changes replace the previous IPC-specific implementations with a more scalable approach using resource registries and handles.
- Implements a unified resource management system with base resource classes and registries
- Replaces direct IPC message passing with resource-based communication
- Introduces syscore library providing user-space APIs for filesystem and IPC operations
- Updates toolchain scripts to support EXT2 filesystem and improved deployment automation
Reviewed Changes
Copilot reviewed 133 out of 140 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| libraries/syscore/* | New user-space library providing abstracted syscall wrappers for filesystem, IPC, and system operations |
| kernel/src/processes/resource.cpp | Core resource management system implementation with registries and handle management |
| kernel/src/processes/ipc.cpp | Refactored IPC to use resource-based approach instead of direct memory management |
| kernel/src/system/syscalls.cpp | Updated syscall handlers to work with unified resource system instead of specific IPC calls |
| programs/Example*/* | Updated example programs to use new syscore library APIs |
| toolchain/* | Enhanced build and deployment scripts with EXT2 support and filesystem synchronization |
Files not reviewed (1)
- .idea/codeStyles/codeStyleConfig.xml: Language not supported
Comments suppressed due to low confidence (1)
kernel/src/processes/resource.cpp:1
- The bounds checking logic is inverted. It should be
ASSERT(index < m_total_entries && bit < s_row_bits, ...)to assert that the indices are within bounds, not outside bounds.
//
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
* Use IDE Interface to find disks * Read MBR Partitions from disk * MS Dos FS Types * Virtual File System * Fat 32 Theory Code, Untested * First half code and comment clean up * First half code and comment clean up * Fix linux FS * Fix directory read recursion * Fix File reading * Fix large rebuild on version changes and grub end of file error * Fix LFN reading * File read/writes * Fix dirnt updates & chain growing for files * FAT 32 TODO Clean up * WIP * Give up on FAT for now * Boot from ext2 * Ext2 Directory Parsing * Ext2 File Reading * Ext2 File Writing * Ext2 File Expanding * String Memory Fixes * Optimisation * Buggy Ext2 Dir Adding * Buffer Class Implementation * Creation of Files/Dirs * Undo Deleted Images * Delete Files & Directories * Rename Directories & Files * Fix Crashing * Fix MaxOS Entry Issues * Fix Style Issues * Process Resource Management * Resource Syscalls & IPC setup * Userspace Resources & IPC * Userspace Files & Directories * More Path stuff * Pre merge fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.