Skip to content

Virtual File System#13

Merged
maxtyson123 merged 38 commits intomainfrom
Virtual-File-System
Sep 2, 2025
Merged

Virtual File System#13
maxtyson123 merged 38 commits intomainfrom
Virtual-File-System

Conversation

@maxtyson123
Copy link
Owner

No description provided.

@maxtyson123 maxtyson123 requested a review from Copilot September 2, 2025 01:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a "Virtual File System" by implementing a unified resource management system that abstracts different resource types (files, directories, shared memory, message endpoints) behind a common interface. The changes replace the previous IPC-specific implementations with a more scalable approach using resource registries and handles.

  • Implements a unified resource management system with base resource classes and registries
  • Replaces direct IPC message passing with resource-based communication
  • Introduces syscore library providing user-space APIs for filesystem and IPC operations
  • Updates toolchain scripts to support EXT2 filesystem and improved deployment automation

Reviewed Changes

Copilot reviewed 133 out of 140 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
libraries/syscore/* New user-space library providing abstracted syscall wrappers for filesystem, IPC, and system operations
kernel/src/processes/resource.cpp Core resource management system implementation with registries and handle management
kernel/src/processes/ipc.cpp Refactored IPC to use resource-based approach instead of direct memory management
kernel/src/system/syscalls.cpp Updated syscall handlers to work with unified resource system instead of specific IPC calls
programs/Example*/* Updated example programs to use new syscore library APIs
toolchain/* Enhanced build and deployment scripts with EXT2 support and filesystem synchronization
Files not reviewed (1)
  • .idea/codeStyles/codeStyleConfig.xml: Language not supported
Comments suppressed due to low confidence (1)

kernel/src/processes/resource.cpp:1

  • The bounds checking logic is inverted. It should be ASSERT(index < m_total_entries && bit < s_row_bits, ...) to assert that the indices are within bounds, not outside bounds.
//

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@maxtyson123 maxtyson123 merged commit 84969b5 into main Sep 2, 2025
2 checks passed
@maxtyson123 maxtyson123 deleted the Virtual-File-System branch September 2, 2025 02:10
github-actions bot pushed a commit that referenced this pull request Sep 2, 2025
* Use IDE Interface to find disks

* Read MBR Partitions from disk

* MS Dos FS Types

* Virtual File System

* Fat 32 Theory Code, Untested

* First half code and comment clean up

* First half code and comment clean up

* Fix linux FS

* Fix directory read recursion

* Fix File reading

* Fix large rebuild on version changes and grub end of file error

* Fix LFN reading

* File read/writes

* Fix dirnt updates & chain growing for files

* FAT 32 TODO Clean up

* WIP

* Give up on FAT for now

* Boot from ext2

* Ext2 Directory Parsing

* Ext2 File Reading

* Ext2 File Writing

* Ext2 File Expanding

* String Memory Fixes * Optimisation

* Buggy Ext2 Dir Adding

* Buffer Class Implementation

* Creation of Files/Dirs

* Undo Deleted Images

* Delete Files & Directories

* Rename Directories & Files

* Fix Crashing

* Fix MaxOS Entry Issues

* Fix Style Issues

* Process Resource Management

* Resource Syscalls & IPC setup

* Userspace Resources & IPC

* Userspace Files & Directories

* More Path stuff

* Pre merge fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants