feat: Phase 2b — data core (DataPoint, Indicators, Levels, SimulationData)#2
Open
may01 wants to merge 4 commits into
Open
feat: Phase 2b — data core (DataPoint, Indicators, Levels, SimulationData)#2may01 wants to merge 4 commits into
may01 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataPointprotocol +LiveDataPoint/WideDataPoint— unified read interface so signals/strategies are path-agnostic (live vs simulation)Indicatorsclass with TA-Lib path and pandas fallback; all columns named{tf}_{indicator}and computed in-placeLevelsclass for support/resistance price level managementSimulationData— O(1) backtesting replay engine over pre-computed wide DataFrameDepends On
PR #1 (Phase 2a — BaseStock, BinanceStock, StockItem)
Test Plan
pytest tests/data/— 38 passed, 0 failedLiveDataPoint.get(col, tf, shift)returns correct scalar; raises KeyError for missing tfWideDataPoint.get()uses position-based indexing with bounds guard🤖 Generated with Claude Code