Add SVG rendering for conference thumbnails#50
Merged
Conversation
* Set up NanoSVG package containing a tiny Swift wrapper around the NanoSVG library. * Add SVGImageView, functioning like `AsyncImage` but for rendering SVGs to bitmaps. Including a small cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thumbnails of the conferences on media.ccc.de use SVG for the conference logos. HackerTube displays these as thumbnails in a grid, but Apple's
AsyncImagecannot render them. Since Apple provides no APIs for SVG rendering, the open source NanoSVG library is a nice option because it's lightweight, can be directly included in this project. And it doesn't matter if the conference logo doesn't render perfectly - it's better than nothing.AsyncImagebut for rendering SVGs to bitmaps. Including a small cache.