issue-2359: fix drag and drop one pixel before slot start case#2383
Closed
the-nelsonator wants to merge 1 commit into
Closed
issue-2359: fix drag and drop one pixel before slot start case#2383the-nelsonator wants to merge 1 commit into
the-nelsonator wants to merge 1 commit into
Conversation
the-nelsonator
changed the title
Owner
|
Thanks. This PR has an issue: when slowly dragging a tab the pointer suddenly jumps to the next slot in "inside" mode. |
Owner
|
And I still can repro the original issue. |
Owner
|
Ok, I found out that a blind zone is not just a pixel but a range from slot.bottom to slot.end. |
Contributor
Author
|
Thanks for the proper fix! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2359
If group you're dragging a tab onto is at index 3 and then in
drag-and-drop.fg.ts#onDragMoveDnD.reactive.dstParentId isn't set, so remains -1, so DnD results in tab being moved to bottom/top of panel depending on config.
Changes allows execution to make it to
// Insidesection when this happens. It handles as expected then.I'm not sure if there's a more elegant fix or if this covers all cases, but this seems to fix this one particular case. If you can find a superset of cases feel free to discard for a better fix.