feat(favorites): Group by stop UI part 1#1835
Conversation
43f3376 to
38005e3
Compare
| Row(horizontalArrangement = Arrangement.spacedBy(-8.dp)) { | ||
| RoutePill(pillDecoration.route, line = null, RoutePillType.FlexCompact) | ||
|
|
||
| predictions.warningAlert?.let { warningAlert -> |
There was a problem hiding this comment.
nitpick: It would reduce the code a bit to have this on a constant and put it here and on the else block
There was a problem hiding this comment.
I'll address this in the follow-up PR where I need to make this section a bit more reusable anyway!
There was a problem hiding this comment.
Actually ended up including in this one
thedecaftony
left a comment
There was a problem hiding this comment.
Now favorites will be group by stop, are we planning to give the pill and text the same padding space so they look more align with each other?
| if (route.id.idText.startsWith("Green-")) { | ||
| when (type) { | ||
| Type.Fixed -> Content.Text(route.longName.replace("Green Line ", "GL ")) | ||
| Type.Fixed, |
There was a problem hiding this comment.
Note: This "GL B" rounded fixed-width pill was never actually used anywhere because we'd instead use the "GL" fixed-width line pill representing the whole line instead of just one GL route.
With these changes, the unused "GL B" rounded fixed-width pill is effectively replaced by the "B" circle pill.
@thedecaftony yes, based on this thread with design! I just pushed a change for that, would you mind re-reviewing this PR? I updated the description with images after this change. |
00e34c0 to
1ab84e3
Compare
Summary
Ticket: Group favorites by stop | Favorites View UI
What is this PR for?
Not included:
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resource in alphabetical order- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?