fix: send full history to fresh SSE connections#13
Open
mc-nekoneko wants to merge 1 commit intomainfrom
Open
Conversation
Previously, history replay only triggered on reconnection with a Last-Event-ID header. New connections (e.g. dashboard initial load) received no history, so recent events were invisible until a new event was fired. Now, fresh connections without Last-Event-ID receive the full stored history on connect, so dashboards show recent activity immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New SSE connections (no
Last-Event-ID) received no history. Dashboard showed "イベント待機中..." even when recent events existed in the ring buffer.Fix
Fresh connections now receive the full stored history on connect.
Reconnections (with
Last-Event-ID) still get only missed events as before.