Add skip_discriminant to skip discriminant comparison in derived PartialEq implementations#116
Open
compiler-errors wants to merge 2 commits intomcarton:masterfrom
Open
Add skip_discriminant to skip discriminant comparison in derived PartialEq implementations#116compiler-errors wants to merge 2 commits intomcarton:masterfrom
skip_discriminant to skip discriminant comparison in derived PartialEq implementations#116compiler-errors wants to merge 2 commits intomcarton:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustc wants to use derivative to simplify
PartialEqderives, but encounters a pretty significant perf hit because thederivative(PartialEq)impl will add a discriminant comparison first, unlike our hand-rolled implementations.This PR adds a
PartialEq = "skip_discriminant"mode to skip generating an initial discriminant comparison so that rustc can derive more tailoredPartialEqimplementations for derivative. This is proven to work.