Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces the error_set_part! macro to enable distributed error set definitions across multiple files. Instead of defining all errors in a single location, developers can now define error parts in different modules, which are automatically combined into a single error_set! macro at build time via the combine_error_set_parts() function.
Key changes:
- Added new
error_set_part!macro that generates use statements for error types - Implemented build-time combining of error_set_part definitions into a centralized error_set.rs file
- Added
combine_partsfeature with theignorecrate dependency for file system traversal - Reorganized examples into an
examples/directory structure
Reviewed changes
Copilot reviewed 13 out of 18 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| error_set_impl/src/lib.rs | Adds new error_set_part! proc macro that extracts error names and generates use statements |
| error_set/src/lib.rs | Exports combine_error_set_parts function when combine_parts feature is enabled |
| error_set/src/combine_parts.rs | Implements file scanning, parsing, and combining logic to merge error_set_part definitions |
| error_set/Cargo.toml | Adds ignore dependency and combine_parts feature (set as default) |
| examples/error_set_part/ | Complete example demonstrating distributed error definitions across multiple files |
| examples/test_no_std/ | Moved from root to examples directory, demonstrates no_std compatibility |
| Cargo.toml | Updates workspace members to include new examples and exclude test_no_std |
| .github/workflows/ci.yml | Updates CI path to reflect test_no_std relocation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.