fix: use factory function for MCP server in stateless mode#71
Merged
fix: use factory function for MCP server in stateless mode#71
Conversation
Deploying mcp-auth-docs with
|
| Latest commit: |
93ca312
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e6a8f629.mcp-auth-docs.pages.dev |
| Branch Preview URL: | https://xiaoyijun-fix-stateless-tran.mcp-auth-docs.pages.dev |
charIeszhao
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the transport handling issue in the todo-manager tutorial code.
Problem: The original code used a singleton
McpServerinstance but calledserver.connect(transport)on every POST request. This is incorrect because in stateless mode, each request should have its own isolated server instance.Solution: Following the MCP SDK's official
simpleStatelessStreamableHttp.jsexample, use a factory functioncreateMcpServer()to create a new server instance for each request.Changes:
McpServercreation and tool registration in acreateMcpServer()factory functioncreateMcpServer()in each POST request handlermcpServer.close()cleanup in the response close handlerapp.get('/')andapp.delete('/')routes that only returned 405 errorsTesting
N/A
Checklist
.changeset