refactor: loose client id requirement and accept azp#23
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JWT verification logic to loosen the requirement on the client_id field and support the azp field as a fallback. Key changes include updating the tests to account for different types of client_id values, modifying the verify_jwt function to check for azp if client_id is absent, and updating the type definitions accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/utils/create_verify_jwt_test.py | Updated tests to verify client_id handling and fallback to azp |
| mcpauth/utils/_create_verify_jwt.py | Refactored JWT verification logic for client_id/azp fallback |
| mcpauth/types.py | Updated type definitions and documentation for client_id and azp support |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
xiaoyijun
approved these changes
May 22, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An update originated from mcp-auth/js#28.
Improved handling of the
client_idfield in the built-in JWT verifier and added support for theazp(authorized party) field. The logic now falls back to theazpfield ifclient_idis missing or malformed. If neither field is valid, it defaults to an empty string.