Open
Conversation
PRV control structure created
mdbartos
reviewed
Feb 7, 2024
Owner
|
Hi Meghna, do you have the working version of the code ready to pull in? |
Author
|
Yes - my most recent commit 820c32c includes the working code with PRV structures and is ready to be pulled! |
Owner
|
Hi @meghnathomas are there any test cases that we can include to verify the results? |
Author
|
Hi @mdbartos just added a folder with some PRV test results! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRV control structure created
note that the u_prv variable here is redundant now - all PRV calculations take place within nsuperlink and are unaffected by u