Feat/copilot cli provider fixed ci errors#10
Closed
atkaksoy501 wants to merge 5 commits into
Closed
Conversation
Add '* text=auto eol=lf' to .gitattributes so git normalises all text files to LF when checking out on Windows. This prevents the 355 Biome formatter errors caused by CRLF endings being injected at checkout time on the windows-latest runner. The existing squad merge=union rules are preserved unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The maker-dmg package pulls a native dependency chain (electron-installer-dmg → appdmg → ds-store → macos-alias) that fails to compile on ARM64 macOS GitHub runners. Since macOS packaging uses a custom shell script (make-macos-app.sh) and not electron-forge makers, this dependency was never used. Removing it and its forge.config.ts references eliminates the CI install failure without affecting any actual packaging flow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…actor Bishop's boundary fix replaced the ProjectPaneIcons import in ProjectPane.tsx instead of adding the new isNoModifierPressed import alongside it. This restores both imports so the component compiles and platform-boundary checks still pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…shortcut tests - Wrap fireEvent.keyDown calls in await act() for turn-related tests to ensure React state updates complete before assertions - Fix 'routes Cmd+Left/Right' test: wait for 'Next page' button to be enabled (confirming canNavigatePages=true) before firing the shortcut, preventing a race where the keydown fires before data has loaded - Add intermediate assertions (turn content, Next turn enabled) to turn-memory tests for clearer failure diagnosis - Refactor inline providerCounts fixtures to use EMPTY_PROVIDER_COUNTS helper to pick up future provider additions automatically - Export EMPTY_PROVIDER_COUNTS and add createSessionMessageFixture to appTestFixtures.ts for reuse across tests - Tighten TurnCombinedMessage type in useHistoryController.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates core and desktop fixtures/configuration to fully account for the copilot_cli provider and related schema updates, while also applying a few CI/stability-oriented formatting and test adjustments.
Changes:
- Add
copilot_cliinto live status/provider-count fixtures and ensure discovery configs includecopilotCliRootin tests. - Update desktop renderer/main tests and fixtures to align with updated IPC message schema (e.g., turn grouping fields), plus minor test timing fixes.
- Adjust Electron Forge config/deps (remove DMG maker) and add
.gitattributesto enforce LF checkouts.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/testing/liveWatchFixtures.ts | Extends live-status fixture providerCounts to include copilot_cli. |
| packages/core/src/testing/inMemory.test.ts | Adds copilotCliRoot to in-memory discovery config used by tests. |
| packages/core/src/parsing/providerParsers.ts | Formatting-only change in Copilot CLI event parsing logic. |
| packages/core/src/discovery/providers/copilotCli.test.ts | Formatting-only changes to expectations/calls. |
| packages/core/src/discovery/discoverSingleFile.test.ts | Adds copilotCliRoot to discovery config helper for tests. |
| packages/core/src/discovery/discoverSessionFiles.test.ts | Ensures discovery configs include copilotCliRoot in relevant tests. |
| apps/desktop/src/renderer/test/appTestFixtures.ts | Exports shared EMPTY_PROVIDER_COUNTS, adds createSessionMessageFixture, and updates fixture messages for new turn fields. |
| apps/desktop/src/renderer/lib/shortcutRegistry.ts | Introduces reusable shortcut constants and an isNoModifierPressed helper. |
| apps/desktop/src/renderer/features/useHistoryController.ts | Uses shared TurnCombinedMessage type for combined-diff detection helper. |
| apps/desktop/src/renderer/components/messages/MessageCard.test.tsx | Switches to shared session-message fixture for test data. |
| apps/desktop/src/renderer/components/history/TurnView.test.tsx | Small typing tweaks for optional fields and provider literal typing. |
| apps/desktop/src/renderer/components/history/ProjectPane.tsx | Reuses isNoModifierPressed to detect unmodified arrow events. |
| apps/desktop/src/renderer/components/ShortcutsDialog.tsx | Uses shared shortcut constants for ranking logic. |
| apps/desktop/src/renderer/components/SettingsView.test.tsx | Uses shared EMPTY_PROVIDER_COUNTS in live status fixture setup. |
| apps/desktop/src/renderer/App.test.tsx | Uses shared provider-counts fixture, adds a couple assertions, and wraps key events in act() for stability. |
| apps/desktop/src/renderer/App.historyMessages.test.tsx | Adds an additional wait to stabilize page-number state before navigation. |
| apps/desktop/src/main/liveSessionStore.test.ts | Adds copilotCliRoot to discovery config for main-process tests. |
| apps/desktop/src/main/historyExport.test.ts | Updates message factory to include new turn-grouping fields. |
| apps/desktop/src/main/data/queryService.test.ts | Tightens mock typing for bookmark list return type. |
| apps/desktop/scripts/measure-message-viewer-performance.tsx | Updates base message to include new turn-grouping fields. |
| apps/desktop/package.json | Removes @electron-forge/maker-dmg dev dependency. |
| apps/desktop/forge.config.ts | Removes DMG maker configuration from Electron Forge. |
| .gitattributes | Enforces LF checkout for text files and sets union merges for .squad logs/history. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
22
to
29
| @@ -27,6 +28,40 @@ const EMPTY_PROVIDER_COUNTS = { | |||
| copilot_cli: 0, | |||
| } as const; | |||
| cursor: 0, | ||
| copilot: 0, | ||
| }, | ||
| providerCounts: EMPTY_PROVIDER_COUNTS, |
| cursor: 0, | ||
| copilot: 0, | ||
| }, | ||
| providerCounts: EMPTY_PROVIDER_COUNTS, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.