fixed ci errors#11
Closed
atkaksoy501 wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR restores CI stability after rebasing onto the latest origin/main, primarily by reconciling upstream changes with existing test/fixture expectations and applying small formatting/lint-safe adjustments so the full pipeline passes again.
Changes:
- Updated/standardized renderer test fixtures to stay type-safe as IPC/types evolved (e.g., shared provider counts, message fixtures).
- Stabilized turn-view related UI tests (notably by restoring
act()usage around shortcut-driven state updates). - Applied minor formatting/import-order changes to satisfy lint/formatting rules across core + desktop packages.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/providers/adapters/opencode.ts | Minor cleanup in OpenCode adapter metadata extraction. |
| packages/core/src/indexing/indexChangedFiles.test.ts | Formatting-only change in a DB assertion to satisfy lint/formatter. |
| packages/core/src/discovery/providers/opencode.ts | Formatting/import order tweaks and small readability improvements. |
| packages/core/src/discovery/discoverSessionFiles.test.ts | Updated fixture paths/expectations for Copilot CLI root changes and formatting. |
| apps/desktop/src/renderer/test/appTestFixtures.ts | Exported shared provider-count defaults and added a typed session-message fixture. |
| apps/desktop/src/renderer/components/messages/MessageCard.test.tsx | Switched to the shared message fixture for type-safe test setup. |
| apps/desktop/src/renderer/components/history/TurnView.test.tsx | Adjusted stub typing (likely for exactOptionalPropertyTypes compatibility). |
| apps/desktop/src/renderer/components/SettingsView.test.tsx | Reused shared provider-count defaults to reduce repetitive literals. |
| apps/desktop/src/renderer/App.test.tsx | Reused provider-count defaults and restored act()-based stabilization for Turn View navigation tests. |
| apps/desktop/src/main/data/queryService.test.ts | Tightened typing in bookmark-store mock using satisfies. |
| apps/desktop/src/main/appStateStore.ts | Formatting-only change for readability/lint compliance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
+27
| const SETTINGS_INFO = createSettingsInfoFixture(); | ||
| const EMPTY_PROVIDER_COUNTS = createProviderRecord(() => 0); | ||
| export const EMPTY_PROVIDER_COUNTS = createProviderRecord(() => 0); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores CI stability on top of the latest
origin/mainafter upstream changes landed between the original fix and the fork update.The branch was rebased onto the current upstream head, the overlapping fixes were merged carefully with the newer OpenCode / cross-platform changes, and the remaining CI regressions were resolved with the smallest
possible delta.
What changed
Commit breakdown
91a2904—fix: restore main CI stabilityReapplies the original CI-fix work on top of the new upstream base.
This commit keeps the necessary test and fixture updates that were still missing after the rebase, while dropping fixes that upstream had already absorbed.
9324942—fix: stabilize rebased CIFinal cleanup after the rebase.
This commit restores the missing
act()-based test stabilization, and includes the minimal formatter/lint-safe updates required for the rebased branch to pass CI cleanly.Validation
bun run ciIf you want a shorter PR body, use this:
Summary
This PR restores CI stability after rebasing our earlier fixes onto the latest
origin/main.Upstream had already absorbed part of the original CI work, so the rebase was resolved by keeping the newer upstream behavior where appropriate and carrying forward only the fixes that were still required.
Commits
91a2904—fix: restore main CI stabilityReconciles the original CI fixes with the current upstream branch and preserves the remaining required test/fixture updates.
9324942—fix: stabilize rebased CIAdds the final post-rebase stabilization and lint/formatting cleanup needed for CI to pass.
Validation
bun run ci