fix: CI Error Fix Retry#12
Closed
atkaksoy501 wants to merge 3 commits into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…E selectors) - Add `* text=auto eol=lf` to .gitattributes to enforce LF on Windows checkouts - Increase waitFor timeout in pagination test for slower CI environments - Fix Playwright strict mode: use `section.history-focus-pane` selector to uniquely target the message pane (avoids 3-element ambiguity) - Fix search E2E: wait for results before asserting focus on first result button - Fix help view E2E: use correct `.help-section-title` class (was .help-group-label) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Restore CI stability and resolve cross-platform failures
Summary
This PR fixes pre-existing CI failures across all three matrix runners (Windows, macOS, Ubuntu) and resolves type/lint drift that accumulated after recent upstream changes. CI has never passed on this repository — these fixes aim to make it green for the first time.
Commits
1.
fix: restore main CI stabilityFixes type errors, lint violations, and test flakiness that prevented
bun run cifrom passing:providerCountsobjects with the sharedEMPTY_PROVIDER_COUNTSspread pattern to satisfy theProviderCountstype after the OpenCode provider was addedsatisfies StoredBookmark[]typing toqueryService.test.tsbookmark fixturescreateSessionMessageFixturehelper inappTestFixtures.tsto centralizeSessionMessageconstructionact()wrappers and readiness waits inApp.test.tsxto eliminate CI-only timing racescopilotCliRootpath indiscoverSessionFiles.test.ts2.
fix: stabilize rebased CIPost-rebase cleanup after merging with upstream's OpenCode provider changes:
appStateStore.ts,opencode.ts, test files)appTestFixtures.ts,discoverSessionFiles.test.ts)let→constin OpenCode adapteract()wrapper inApp.test.tsxturn navigation test3.
fix: resolve cross-platform CI failures (Windows CRLF, test races, E2E selectors)Fixes failures that affected all three CI runners:
.gitattributesdidn't enforce LF — Biome rejected 363 files with CRLF* text=auto eol=lfto.gitattributesApp.test.tsxpagination test timed out —waitFordefault 1s too short for CIwaitFortimeout to 5000ms.history-focus-panematched 3 elements (strict mode violation)section.history-focus-paneto uniquely target the message pane<div>.help-group-labelselector doesn't exist in codebase.help-section-title(the actual class)Testing
bun run cipasses locally (lint → platform-boundaries → typecheck → 982 tests → coverage)