Muhammad Ahsan Mahfuz k22044399 Individual Project#231
Muhammad Ahsan Mahfuz k22044399 Individual Project#231AhsanM1470 wants to merge 16 commits intomdenet:mainfrom
Conversation
|
Closes #208. |
|
Many thanks, @AhsanM1470 for submitting this PR. Could you please update your branch based on the latest base branch to see if this causes any issues? I'm aware that our tests are currently failing on this PR. This seems to be to do with how we have set up the GitHub Action rather than with any actual failures in the tests. @aryaei2000, could you look into this at some point, please? |
|
Thank you for your response @szschaler. I have updated my branch, and all the features and unit tests are working correctly on my end. Please let me know if everything looks good to you or if you need anything else. |
|
I notice that some of the tests don't seem to run successfully and this doesn't look like it's the issue with uploading test reports, but an actual issue with the tests. @AhsanM1470, could you take a look at the check reports and see if you can work out what's going on here? |
|
@szschaler I looked through the reports and saw the headless Firefox tests were failing. I think the failures have something to do with the HTML reporter plugin rather than the tests themselves. I updated both the jasmine-core and karma-jasmine-html-reporter packages to their latest versions locally, and now all the tests pass for me. Could you let me know if this fixes things on your end? |
|
Thanks. Could you add those changes to the branch here, please? |
|
Sure thing, the changes have been added now |
|
Thanks, @AhsanM1470, this all looks good now. We are only left with errors from test reporting, which are due to GitHub permissions. We're aware of these and need to implement a solution separately... |
|
Partially addresses #233 . |
Summary
This pull request integrates instructions directly into the MDENet Education Platform via two new features: an instruction panel and interactive guide.
Instruction Panel
Interactive Guide