Skip to content

Muhammad Ahsan Mahfuz k22044399 Individual Project#231

Open
AhsanM1470 wants to merge 16 commits intomdenet:mainfrom
AhsanM1470:main
Open

Muhammad Ahsan Mahfuz k22044399 Individual Project#231
AhsanM1470 wants to merge 16 commits intomdenet:mainfrom
AhsanM1470:main

Conversation

@AhsanM1470
Copy link

@AhsanM1470 AhsanM1470 commented Apr 23, 2025

Summary

This pull request integrates instructions directly into the MDENet Education Platform via two new features: an instruction panel and interactive guide.

Instruction Panel

  • Added as a new utility panel.
  • Loads content from a Markdown instruction file, located in the same repository as the activity configuration file.
  • Includes checkboxes on instruction steps for learners to manually track their progress.
  • Includes a progress bar that updates automatically as steps are checked off.

Interactive Guide

  • Introduces draggable text bubbles to display instruction steps and guide learners through the activity.
  • Uses metadata comments defined in the instruction markdown file to control behaviour.
  • Metadata defines which panel a text bubble's tell should point to, and which panels to spotlight while the rest of the screen is dimmed.

@szschaler szschaler added the enhancement New feature or request label Apr 24, 2025
@szschaler szschaler moved this to In review in Education Platform Apr 24, 2025
@szschaler szschaler requested a review from aryaei2000 April 24, 2025 08:17
@szschaler
Copy link
Contributor

Closes #208.

@szschaler
Copy link
Contributor

Many thanks, @AhsanM1470 for submitting this PR. Could you please update your branch based on the latest base branch to see if this causes any issues?

I'm aware that our tests are currently failing on this PR. This seems to be to do with how we have set up the GitHub Action rather than with any actual failures in the tests. @aryaei2000, could you look into this at some point, please?

@AhsanM1470
Copy link
Author

Thank you for your response @szschaler. I have updated my branch, and all the features and unit tests are working correctly on my end. Please let me know if everything looks good to you or if you need anything else.

@szschaler
Copy link
Contributor

I notice that some of the tests don't seem to run successfully and this doesn't look like it's the issue with uploading test reports, but an actual issue with the tests. @AhsanM1470, could you take a look at the check reports and see if you can work out what's going on here?

@AhsanM1470
Copy link
Author

AhsanM1470 commented Apr 26, 2025

@szschaler I looked through the reports and saw the headless Firefox tests were failing. I think the failures have something to do with the HTML reporter plugin rather than the tests themselves. I updated both the jasmine-core and karma-jasmine-html-reporter packages to their latest versions locally, and now all the tests pass for me. Could you let me know if this fixes things on your end?

@szschaler
Copy link
Contributor

Thanks. Could you add those changes to the branch here, please?

@AhsanM1470
Copy link
Author

Sure thing, the changes have been added now

@szschaler
Copy link
Contributor

Thanks, @AhsanM1470, this all looks good now. We are only left with errors from test reporting, which are due to GitHub permissions. We're aware of these and need to implement a solution separately...

@szschaler szschaler mentioned this pull request Jul 11, 2025
@szschaler
Copy link
Contributor

Partially addresses #233 .

@szschaler szschaler linked an issue Jul 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Guided Activities

2 participants