Detect node architecture to enable MacOS M* (ARM-based processors) builds#108
Detect node architecture to enable MacOS M* (ARM-based processors) builds#108szschaler merged 1 commit intomdenet:mainfrom
Conversation
|
Thanks, @LinusDietz. Quick question: is there a reason why you didn't go with the solution originally proposed in mdenet/educationplatform-docker#65? |
|
I didn't understand what the solution was concretely? I did actually not try that. If there is a more straightforward way to solve it, that's great. |
There was a problem hiding this comment.
Pull request overview
Updates the Xtext container build to install the correct Node.js binary for the build architecture, enabling successful builds on Apple Silicon (arm64) while retaining x64 compatibility.
Changes:
- Replaces a fixed
linux-x64Node.js release selection with runtime architecture detection (dpkg --print-architecture). - Installs the appropriate Node.js tarball for
linux-arm64vslinux-x64and standardizes the install path via a/usr/local/nodesymlink. - Updates
PATHto use the symlinked Node install directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks. I haven't got a Mac, so am unsure about the solution proposed in the original issue myself. It compiles on my Linux VM, so I'll give it a spin on Github CI... |
|
In the meantime, what are your thoughts, @LinusDietz, on what CoPilot has suggested above? |
|
So, this builds successfully on GitHub CI (see mdenet/educationplatform-docker#82). Once we have formed an opinion on the Copilot comments here, I'm happy to get this integrated. |
|
The copilot comments feel a bit nitpicky in the context of the educational platform.
|
This fixes mdenet/educationplatform-docker#65
Tested on a Apple M2 Pro (Sequoia 15.7.4)