Open
Conversation
Fred78290
added a commit
to Fred78290/vsock
that referenced
this pull request
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #50 the user @dimalinux proposed updating from an error string the the
net.ErrClosedlibrary. As mentioned by @dimalinux, this change keeps the error string the same, while updating the behavior of the vsock library to be similar to the standard library. One benefit is that with this change, a user can now check for the error viainstead of comparing error strings.
I only made the change in the code but I am happy to add a test for this but I was not sure where the correct place would be. Any guidance on that would be great!