Draft
Conversation
Contributor
|
01dd10c was deployed to: https://fred-pr1312.review.mdn.allizom.net/ |
Contributor
Author
|
At first, I thought the new behavior for CSS properties is confusing, but it's actually consistent with the current behavior at the top level, so I think it's fine. |
Member
|
I think this is overly complex, and piles on the edge-cases - a path we already know to be dangerous with the sidebars. I'd first take a step back and re-evaluate how we consider the sidebar hierarchy, which I've attempted to do in #1311 (comment). We can then revisit and fix some remaining edge-cases with the not-yet-baseline-green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
left-sidebarlayout, unindenting nested details:Motivation
Additional details
Related issues and pull requests
Fixes #1311.