fix(curriculum): modules not displaying on landing page#623
Merged
Conversation
fix(curriculum): sidebar not nesting correctly
Contributor
|
ee69105 was deployed to: https://rari-pr623.review.mdn.allizom.net/ |
caugner
approved these changes
Apr 14, 2026
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
LGTM. IIUC the regression was caused by stripping the /curriculum path from inside the curriculum repo, causing the levels to be off by one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in 32943d5 to how we constructed the curriculum path broke how detected modules: this broke the display on the homepage, and nesting in the sidebar.