Skip to content

Added speed, position and aria options#87

Open
T-Fletcher wants to merge 29 commits intomeanthemes:masterfrom
T-Fletcher:master
Open

Added speed, position and aria options#87
T-Fletcher wants to merge 29 commits intomeanthemes:masterfrom
T-Fletcher:master

Conversation

@T-Fletcher
Copy link
Copy Markdown

Added a few options for flexibility and accessibility:

  • meanSpeed: 300 - an integer that sets the speed of all animations in milliseconds e.g. 1000 = 1 second
  • meanExpandPosition: after, options: before/after` to change where the expand/contract icon is inserted in the list markup
  • meanAria: true, options: true/false - adds aria-expanded, aria-label and role attributes

All included in the readme with their default options

T-Fletcher added 29 commits May 12, 2018 10:59
User should be able to switch between adding the expand/collapse link before or after the child menu.
User should be able to switch between adding the expand/collapse link before or after the child menu.
Also updated the selection method of child menu expand/collapse links to use CSS direct decendent selectors rather than the original '.parent()' system
Added meanExpandPosition option and updated README
merging master into meanExpandPosition-test-1
Removed reference to incomplete work that was actually completed in this version
Added 'meanAria' option to include 'aria-expanded', 'aria-label' and 'role' on expand links for screenreaders
Includes new `meanAria` option in action
updated incorrect version number in commit message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant